netdev - Re: [PATCH net] tcp: ulp: fix possible crash in tcp_diag_get_aux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190907.173421.792716263211692531.davem@davemloft.net>
Date:   Sat, 07 Sep 2019 17:34:21 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        lukehsiao@...gle.com, ncardwell@...gle.com, dcaratti@...hat.com
Subject: Re: [PATCH net] tcp: ulp: fix possible crash in
 tcp_diag_get_aux_size()

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu,  5 Sep 2019 13:20:41 -0700

> tcp_diag_get_aux_size() can be called with sockets in any state.
> 
> icsk_ulp_ops is only present for full sockets.
> 
> For SYN_RECV or TIME_WAIT ones we would access garbage.
> 
> Fixes: 61723b393292 ("tcp: ulp: add functions to dump ulp-specific information")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Luke Hsiao <lukehsiao@...gle.com>
> Reported-by: Neal Cardwell <ncardwell@...gle.com>

Applied to net-next, thanks Eric.