netdev - Re: [PATCH] net-ipv6: addrconf_f6i_alloc - fix non-null pointer check to !IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190907.174812.440810335403861625.davem@davemloft.net>
Date:   Sat, 07 Sep 2019 17:48:12 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     zenczykowski@...il.com
Cc:     maze@...gle.com, netdev@...r.kernel.org, dsahern@...il.com,
        lorenzo@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH] net-ipv6: addrconf_f6i_alloc - fix non-null pointer
 check to !IS_ERR()

From: Maciej Żenczykowski <zenczykowski@...il.com>
Date: Thu,  5 Sep 2019 20:56:37 -0700

> From: Maciej Żenczykowski <maze@...gle.com>
> 
> Fixes a stupid bug I recently introduced...
> ip6_route_info_create() returns an ERR_PTR(err) and not a NULL on error.
> 
> Fixes: d55a2e374a94 ("net-ipv6: fix excessive RTF_ADDRCONF flag on ::1/128 local route (and others)'")
> Cc: David Ahern <dsahern@...il.com>
> Cc: Lorenzo Colitti <lorenzo@...gle.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>

Applied and queued up for -stable since I queued up the patch this fixes.