netdev - Re: [Patch net] sch_hhf: ensure quantum and hhf_non_hh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190910.193143.1163269111251640073.davem@davemloft.net>
Date:   Tue, 10 Sep 2019 19:31:43 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+bc6297c11f19ee807dc2@...kaller.appspotmail.com,
        syzbot+041483004a7f45f1f20a@...kaller.appspotmail.com,
        syzbot+55be5f513bed37fc4367@...kaller.appspotmail.com,
        jhs@...atatu.com, jiri@...nulli.us, vtlam@...gle.com
Subject: Re: [Patch net] sch_hhf: ensure quantum and hhf_non_hh_weight are
 non-zero

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Sun,  8 Sep 2019 13:40:51 -0700

> In case of TCA_HHF_NON_HH_WEIGHT or TCA_HHF_QUANTUM is zero,
> it would make no progress inside the loop in hhf_dequeue() thus
> kernel would get stuck.
> 
> Fix this by checking this corner case in hhf_change().
> 
> Fixes: 10239edf86f1 ("net-qdisc-hhf: Heavy-Hitter Filter (HHF) qdisc")
> Reported-by: syzbot+bc6297c11f19ee807dc2@...kaller.appspotmail.com
> Reported-by: syzbot+041483004a7f45f1f20a@...kaller.appspotmail.com
> Reported-by: syzbot+55be5f513bed37fc4367@...kaller.appspotmail.com
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
> Cc: Terry Lam <vtlam@...gle.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable.