netdev - syzbot report in rsi_91x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1909102049130.2551@hadrien>
Date:   Tue, 10 Sep 2019 21:11:16 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     amitkarwar@...il.com, siva8118@...il.com
cc:     syzkaller-bugs@...glegroups.com, kvalo@...eaurora.org,
        davem@...emloft.net, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: syzbot report in rsi_91x_usb.c

Hello,

I spent some time looking at:

https://syzkaller.appspot.com/bug?id=c1b6aa968706d9380dcdb98a9f2c338071cc938c

which does not yet report that it has been fixed.

The problem seems to be in rsi_probe in
drivers/net/wireless/rsi/rsi_91x_usb.c.  This ends with the following
code:

        status = rsi_rx_urb_submit(adapter, WLAN_EP);
        if (status)
                goto err1;

        if (adapter->priv->coex_mode > 1) {
                status = rsi_rx_urb_submit(adapter, BT_EP);
                if (status)
                        goto err1;
        }

        return 0;
err1:
        rsi_deinit_usb_interface(adapter);
err:
        rsi_91x_deinit(adapter);

The problem seems to be that the first call to rsi_rx_urb_submit succeeds,
submitting an urb, and then theh second one fails.  Both share adapter,
which is used in rsi_rx_done_handler, invoked later as the callback
provided with usb_submit_urb.  But adapter, and in particular its rsi_dev
field, are freed by the rsi_91x_deinit call due to the failure of the
second call to rsi_rx_urb_submit.

How should this be fixed?

thanks,
julia