netdev - Re: [PATCH net] net/rds: An rds_sock is added too early to the hash table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Sep 2019 16:06:03 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     ka-cheong.poon@...cle.com
Cc:     netdev@...r.kernel.org, santosh.shilimkar@...cle.com,
        rds-devel@....oracle.com
Subject: Re: [PATCH net] net/rds: An rds_sock is added too early to the
 hash table

From: Ka-Cheong Poon <ka-cheong.poon@...cle.com>
Date: Wed, 11 Sep 2019 02:58:05 -0700

> In rds_bind(), an rds_sock is added to the RDS bind hash table before
> rs_transport is set.  This means that the socket can be found by the
> receive code path when rs_transport is NULL.  And the receive code
> path de-references rs_transport for congestion update check.  This can
> cause a panic.  An rds_sock should not be added to the bind hash table
> before all the needed fields are set.
> 
> Reported-by: syzbot+4b4f8163c2e246df3c4c@...kaller.appspotmail.com
> Signed-off-by: Ka-Cheong Poon <ka-cheong.poon@...cle.com>

Applied.