netdev - Re: [PATCH net v2 01/11] net: core: limit nested device depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190912.003209.917226424625610557.davem@davemloft.net>
Date:   Thu, 12 Sep 2019 00:32:09 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com,
        andy@...yhouse.net, jiri@...nulli.us, sd@...asysnail.net,
        roopa@...ulusnetworks.com, saeedm@...lanox.com,
        manishc@...vell.com, rahulv@...vell.com, kys@...rosoft.com,
        haiyangz@...rosoft.com, sthemmin@...rosoft.com, sashal@...nel.org,
        hare@...e.de, varun@...lsio.com, ubraun@...ux.ibm.com,
        kgraul@...ux.ibm.com, jay.vosburgh@...onical.com
Subject: Re: [PATCH net v2 01/11] net: core: limit nested device depth

From: Taehee Yoo <ap420073@...il.com>
Date: Sat,  7 Sep 2019 22:45:32 +0900

> Current code doesn't limit the number of nested devices.
> Nested devices would be handled recursively and this needs huge stack
> memory. So, unlimited nested devices could make stack overflow.
 ...
> Splat looks like:
> [  140.483124] BUG: looking up invalid subclass: 8
> [  140.483505] turning off the locking correctness validator.

The limit here is not stack memory, but a limit in the lockdep
validator, which can probably be fixed by other means.

This was the feedback I saw given for the previous version of
this series as well.