netdev - Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21ead3ce-25d8-8be8-d7e6-46450fcd38b8@pensando.io>
Date:   Thu, 12 Sep 2019 18:54:10 +0100
From:   Shannon Nelson <snelson@...sando.io>
To:     Jonathan Tooker <jonathan@...iablehosting.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        intel-wired-lan@...ts.osuosl.org
Cc:     Michael Marley <michael@...haelmarley.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

On 9/12/19 5:33 PM, Jonathan Tooker wrote:
> On 9/12/2019 6:01 AM, Steffen Klassert wrote:
>> The ixgbe driver currently does IPsec TX offloading
>> based on an existing secpath. However, the secpath
>> can also come from the RX side, in this case it is
>> misinterpreted for TX offload and the packets are
>> dropped with a "bad sa_idx" error. Fix this by using
>> the xfrm_offload() function to test for TX offload.
>>
> Does this patch also need to be ported to the ixgbevf driver? I can 
> replicate the bad sa_idx error using a VM that's using a VF & the 
> ixgebvf  driver.
>

Yes.
sln