netdev - Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2783711bae4ed87e2210894bcd980f8a3f052e94.camel@intel.com>
Date:   Thu, 12 Sep 2019 08:57:44 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     David Miller <davem@...emloft.net>, steffen.klassert@...unet.com
Cc:     intel-wired-lan@...ts.osuosl.org, michael@...haelmarley.com,
        snelson@...sando.io, netdev@...r.kernel.org
Subject: Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

On Thu, 2019-09-12 at 13:43 +0200, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@...unet.com>
> Date: Thu, 12 Sep 2019 13:01:44 +0200
> 
> > The ixgbe driver currently does IPsec TX offloading
> > based on an existing secpath. However, the secpath
> > can also come from the RX side, in this case it is
> > misinterpreted for TX offload and the packets are
> > dropped with a "bad sa_idx" error. Fix this by using
> > the xfrm_offload() function to test for TX offload.
> > 
> > Fixes: 592594704761 ("ixgbe: process the Tx ipsec offload")
> > Reported-by: Michael Marley <michael@...haelmarley.com>
> > Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> 
> I'll apply this directly and queue it up for -stable, thanks.

Thanks Dave!

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)