netdev - Re: [PATCH net-next] ip: support SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190913.204434.1507890936678622830.davem@davemloft.net>
Date:   Fri, 13 Sep 2019 20:44:34 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net-next] ip: support SO_MARK cmsg

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Wed, 11 Sep 2019 15:50:51 -0400

> From: Willem de Bruijn <willemb@...gle.com>
> 
> Enable setting skb->mark for UDP and RAW sockets using cmsg.
> 
> This is analogous to existing support for TOS, TTL, txtime, etc.
> 
> Packet sockets already support this as of commit c7d39e32632e
> ("packet: support per-packet fwmark for af_packet sendmsg").
> 
> Similar to other fields, implement by
> 1. initialize the sockcm_cookie.mark from socket option sk_mark
> 2. optionally overwrite this in ip_cmsg_send/ip6_datagram_send_ctl
> 3. initialize inet_cork.mark from sockcm_cookie.mark
> 4. initialize each (usually just one) skb->mark from inet_cork.mark
> 
> Step 1 is handled in one location for most protocols by ipcm_init_sk
> as of commit 351782067b6b ("ipv4: ipcm_cookie initializers").
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Looks good, applied.