netdev - Re: [net] ixgbevf: Fix secpath usage for IPsec Tx offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190913.145306.2183002667534995204.davem@davemloft.net>
Date:   Fri, 13 Sep 2019 14:53:06 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     netdev@...r.kernel.org, snelson@...sando.io,
        jonathan@...iablehosting.com
Subject: Re: [net] ixgbevf: Fix secpath usage for IPsec Tx offload

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 12 Sep 2019 12:07:34 -0700

> Port the same fix for ixgbe to ixgbevf.
> 
> The ixgbevf driver currently does IPsec Tx offloading
> based on an existing secpath. However, the secpath
> can also come from the Rx side, in this case it is
> misinterpreted for Tx offload and the packets are
> dropped with a "bad sa_idx" error. Fix this by using
> the xfrm_offload() function to test for Tx offload.
> 
> CC: Shannon Nelson <snelson@...sando.io>
> Fixes: 7f68d4306701 ("ixgbevf: enable VF IPsec offload operations")
> Reported-by: Jonathan Tooker <jonathan@...iablehosting.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, and like the ixgbe version of this fix I queued it up for -stable.

Thanks.