netdev - RE: [PATCH v4 net-next 4/6] net: dsa: sja1105: Advertise the 8 TX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 15 Sep 2019 16:41:15 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "vinicius.gomes@...el.com" <vinicius.gomes@...el.com>,
        "vedang.patel@...el.com" <vedang.patel@...el.com>,
        "richardcochran@...il.com" <richardcochran@...il.com>
CC:     "weifeng.voon@...el.com" <weifeng.voon@...el.com>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "m-karicheri2@...com" <m-karicheri2@...com>,
        "jose.abreu@...opsys.com" <Jose.Abreu@...opsys.com>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "kurt.kanzenbach@...utronix.de" <kurt.kanzenbach@...utronix.de>,
        "joergen.andreasen@...rochip.com" <joergen.andreasen@...rochip.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v4 net-next 4/6] net: dsa: sja1105: Advertise the 8 TX
 queues

From: Vladimir Oltean <olteanv@...il.com>
Date: Sep/15/2019, 03:00:01 (UTC+00:00)

> Instead of looking directly at skb->priority during xmit, let's get the
> netdev queue and the queue-to-traffic-class mapping, and put the
> resulting traffic class into the dsa_8021q PCP field. The switch is
> configured with a 1-to-1 PCP-to-ingress-queue-to-egress-queue mapping
> (see vlan_pmap in sja1105_main.c), so the effect is that we can inject
> into a front-panel's egress traffic class through VLAN tagging from
> Linux, completely transparently.

Wouldn't it be better to just rely on skb queue mapping as per userspace 
settings ? I mean this way you cant create some complex scenarios 
without having the VLAN ID need.

I generally use u32 filter and skbedit queue_mapping action to achieve 
this.

---
Thanks,
Jose Miguel Abreu