netdev - Re: [patch iproute2-next v4 0/2] devlink: couple forgotten flash patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f32dc69-7cc1-4488-a1b6-94db64748630@gmail.com>
Date:   Sun, 15 Sep 2019 11:58:33 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>, David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        jakub.kicinski@...ronome.com, saeedm@...lanox.com,
        mlxsw@...lanox.com, f.fainelli@...il.com
Subject: Re: [patch iproute2-next v4 0/2] devlink: couple forgotten flash
 patches

On 9/14/19 12:00 AM, Jiri Pirko wrote:
> Fri, Sep 13, 2019 at 07:25:07PM CEST, dsahern@...il.com wrote:
>> On 9/12/19 12:29 PM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@...lanox.com>
>>>
>>> I was under impression they are already merged, but apparently they are
>>> not. I just rebased them on top of current iproute2 net-next tree.
>>>
>>
>> they were not forgotten; they were dropped asking for changes.
>>
>> thread is here:
>> https://lore.kernel.org/netdev/20190604134450.2839-3-jiri@resnulli.us/
> 
> Well not really. The path was discussed in the thread. However, that is
> unrelated to the changes these patches do. The flashing itself is
> already there and present. These patches only add status.
> 
> Did I missed something?
> 

you are thinking like a kernel developer and not a user.

The second patch has a man page change that should state that firmware
files are expected to be in /lib/firmware and that path is added by the
kernel so the path passed on the command line needs to drop that part.