netdev - Re: [PATCH net] ibmvnic: Warn unknown speed message only when carrier is present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de449a43-0313-f231-c6cc-40b6f4966a5a@linux.ibm.com>
Date:   Mon, 16 Sep 2019 10:21:47 -0500
From:   Thomas Falcon <tlfalcon@...ux.ibm.com>
To:     Murilo Fossa Vicentini <muvic@...ux.ibm.com>,
        netdev@...r.kernel.org
Cc:     muvic@...ibm.com, abdhalee@...ux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Warn unknown speed message only when carrier
 is present

On 9/16/19 9:50 AM, Murilo Fossa Vicentini wrote:
> With commit 0655f9943df2 ("net/ibmvnic: Update carrier state after link
> state change") we are now able to detect when the carrier is properly
> present in the device, so only report an unexpected unknown speed when it
> is properly detected. Unknown speed is expected to be seen by the device
> in case the backing device has no link detected.
>
> Reported-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> Tested-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> Signed-off-by: Murilo Fossa Vicentini <muvic@...ux.ibm.com>
> ---

Thanks, Murilo!

Reviewed-by: Thomas Falcon <tlfalcon@...ux.ibm.com>

>   drivers/net/ethernet/ibm/ibmvnic.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 5cb55ea671e3..3a6725daf7dc 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -4312,13 +4312,14 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq,
>   {
>   	struct net_device *netdev = adapter->netdev;
>   	int rc;
> +	__be32 rspeed = cpu_to_be32(crq->query_phys_parms_rsp.speed);
>   
>   	rc = crq->query_phys_parms_rsp.rc.code;
>   	if (rc) {
>   		netdev_err(netdev, "Error %d in QUERY_PHYS_PARMS\n", rc);
>   		return rc;
>   	}
> -	switch (cpu_to_be32(crq->query_phys_parms_rsp.speed)) {
> +	switch (rspeed) {
>   	case IBMVNIC_10MBPS:
>   		adapter->speed = SPEED_10;
>   		break;
> @@ -4344,8 +4345,8 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq,
>   		adapter->speed = SPEED_100000;
>   		break;
>   	default:
> -		netdev_warn(netdev, "Unknown speed 0x%08x\n",
> -			    cpu_to_be32(crq->query_phys_parms_rsp.speed));
> +		if (netif_carrier_ok(netdev))
> +			netdev_warn(netdev, "Unknown speed 0x%08x\n", rspeed);
>   		adapter->speed = SPEED_UNKNOWN;
>   	}
>   	if (crq->query_phys_parms_rsp.flags1 & IBMVNIC_FULL_DUPLEX)