| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Sep 2019 06:58:44 +0000
From: "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To: "davem@...emloft.net" <davem@...emloft.net>
CC: "linux-stm32@...md-mailman.stormreply.com"
<linux-stm32@...md-mailman.stormreply.com>,
"joabreu@...opsys.com" <joabreu@...opsys.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"peppe.cavallaro@...com" <peppe.cavallaro@...com>,
"alexandre.torgue@...com" <alexandre.torgue@...com>
Subject: Re: [PATCH v2] net: stmmac: socfpga: re-use the `interface` parameter
from platform data
On Sun, 2019-09-15 at 19:51 +0100, David Miller wrote:
> [External]
>
> From: Alexandru Ardelean <alexandru.ardelean@...log.com>
> Date: Thu, 12 Sep 2019 16:28:50 +0300
>
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-
> > socfpga.c
> > index c141fe783e87..5b6213207c43 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> ...
> > +static inline int socfpga_get_plat_phymode(struct socfpga_dwmac *dwmac)
>
> Please do not use the inline keyword in foo.c files, let the compiler device.
Ack.
Will remove.
Powered by blists - more mailing lists