netdev - Re: [PATCH net-next v2 0/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Sep 2019 08:14:47 +0000
From:   Shalom Toledo <shalomt@...lanox.com>
To:     Ido Schimmel <idosch@...sch.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     Jiri Pirko <jiri@...lanox.com>, mlxsw <mlxsw@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next v2 0/3] mlxsw: spectrum_buffers: Add the ability
 to query the CPU port's shared buffer

Hi David,

I have v3 with all the fixes Jiri commented. Can I send it? Or should I wait
until net-next will be open again?

Thanks,
Shalom.

On 16/09/2019 9:17, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...lanox.com>
> 
> Shalom says:
> 
> While debugging packet loss towards the CPU, it is useful to be able to
> query the CPU port's shared buffer quotas and occupancy.
> 
> Patch #1 prevents changing the CPU port's threshold and binding.
> 
> Patch #2 registers the CPU port with devlink.
> 
> Patch #3 adds the ability to query the CPU port's shared buffer quotas and
> occupancy.
> 
> v2:
> 
> Patch #1:
> * s/0/MLXSW_PORT_CPU_PORT/
> * Assign "mlxsw_sp->ports[MLXSW_PORT_CPU_PORT" at the end of
>   mlxsw_sp_cpu_port_create() to avoid NULL assignment on error path
> * Add common functions for mlxsw_core_port_init/fini()
> 
> Patch #2:
> * Move "changing CPU port's threshold and binding" check to a separate
>   patch
> 
> Shalom Toledo (3):
>   mlxsw: spectrum_buffers: Prevent changing CPU port's configuration
>   mlxsw: spectrum: Register CPU port with devlink
>   mlxsw: spectrum_buffers: Add the ability to query the CPU port's
>     shared buffer
> 
>  drivers/net/ethernet/mellanox/mlxsw/core.c    | 65 ++++++++++++++++---
>  drivers/net/ethernet/mellanox/mlxsw/core.h    |  5 ++
>  .../net/ethernet/mellanox/mlxsw/spectrum.c    | 46 +++++++++++++
>  .../mellanox/mlxsw/spectrum_buffers.c         | 51 ++++++++++++---
>  4 files changed, 150 insertions(+), 17 deletions(-)
>