netdev - RE: [PATCH V1 net-next 01/11] net: ena: add intr_moder_rx_interval to struct ena_com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <681f96d217b24b9f929da7ac61019e72@EX13D22EUA004.ant.amazon.com>
Date:   Mon, 16 Sep 2019 11:39:39 +0000
From:   "Kiyanovski, Arthur" <akiyano@...zon.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>,
        "Jubran, Samih" <sameehj@...zon.com>,
        "Dagan, Noam" <ndagan@...zon.com>
Subject: RE: [PATCH V1 net-next 01/11] net: ena: add intr_moder_rx_interval to
 struct ena_com_dev and use it

> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Sunday, September 15, 2019 9:33 PM
> To: Kiyanovski, Arthur <akiyano@...zon.com>
> Cc: netdev@...r.kernel.org; Woodhouse, David <dwmw@...zon.co.uk>;
> Machulsky, Zorik <zorik@...zon.com>; Matushevsky, Alexander
> <matua@...zon.com>; Bshara, Saeed <saeedb@...zon.com>; Wilson, Matt
> <msw@...zon.com>; Liguori, Anthony <aliguori@...zon.com>; Bshara,
> Nafea <nafea@...zon.com>; Tzalik, Guy <gtzalik@...zon.com>; Belgazal,
> Netanel <netanel@...zon.com>; Saidi, Ali <alisaidi@...zon.com>;
> Herrenschmidt, Benjamin <benh@...zon.com>; Jubran, Samih
> <sameehj@...zon.com>; Dagan, Noam <ndagan@...zon.com>
> Subject: Re: [PATCH V1 net-next 01/11] net: ena: add intr_moder_rx_interval to
> struct ena_com_dev and use it
> 
> From: <akiyano@...zon.com>
> Date: Fri, 13 Sep 2019 01:08:38 +0300
> 
> > @@ -1307,8 +1304,8 @@ static void
> ena_com_update_intr_delay_resolution(struct ena_com_dev *ena_dev,
> >  	ena_dev->intr_delay_resolution = intr_delay_resolution;
> >
> >  	/* update Rx */
> > -	for (i = 0; i < ENA_INTR_MAX_NUM_OF_LEVELS; i++)
> > -		intr_moder_tbl[i].intr_moder_interval /= intr_delay_resolution;
> > +	ena_dev->intr_moder_rx_interval /= intr_delay_resolution;
> > +
> >
> >  	/* update Tx */
> 
> Now there are two empty lines here, please remove one of them.

Thanks.
For some reason checkpatch did not catch this and also another such extra space.
Sent out V2 of the patchset.