netdev - Re: [PATCH net] ipv4: Revert removal of rt_uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9afca894-3807-632a-529b-7ceee4227bcb@gmail.com>
Date:   Tue, 17 Sep 2019 12:55:58 -0600
From:   David Ahern <dsahern@...il.com>
To:     Julian Anastasov <ja@....bg>, David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv4: Revert removal of rt_uses_gateway

On 9/17/19 12:50 PM, Julian Anastasov wrote:
> 
> 	Looks good to me, thanks!
> 
> Reviewed-by: Julian Anastasov <ja@....bg>
> 

BTW, do you have any tests for the rt_uses_gateway paths - showing why
it is needed?

All of the pmtu, redirect, fib tests, etc worked fine without the
special flag. Sure, the 'ip ro get' had extra data; it seems like that
could be handled.