lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Sep 2019 22:55:05 +0200 From: Andrew Lunn <andrew@...n.ch> To: Iwan R Timmer <irtimmer@...il.com> Cc: Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring On Tue, Sep 17, 2019 at 10:23:01PM +0200, Iwan R Timmer wrote: > Add support for configuring port mirroring through the cls_matchall > classifier. We do a full ingress and/or egress capture towards the > capture port, configured with set_egress_port. Hi Iwan This looks good as far as it goes. Have you tried adding/deleting multiple port mirrors? Do we need to limit how many are added. A quick look at the datasheet, you can define one egress mirror port and one ingress mirror port. I think you can have multiple ports mirroring ingress to that one ingress mirror port. And you can have multiple port mirroring egress to the one egress mirror port. We should add code to check this, and return -EBUSY if the existing configuration prevents a new mirror being configured. Thanks Andrew
Powered by blists - more mailing lists