netdev - Re: [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Sep 2019 21:12:23 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Björn Töpel <bjorn.topel@...il.com>,
        Yonghong Song <yhs@...com>
Subject: Re: [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS

On Mon, Sep 16, 2019 at 6:05 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> The xsk_socket__create() function fails and returns an error if it cannot
> get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS
> was not added until kernel 5.3, so this means that creating XSK sockets
> always fails on older kernels.
>
> Since the option is just used to set the zero-copy flag in the xsk struct,
> and that flag is not really used for anything yet, just remove the
> getsockopt() call until a proper use for it is introduced.
>
> Suggested-by: Yonghong Song <yhs@...com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> ---
> v2:
>   - Remove the call entirely.
>
>  tools/lib/bpf/xsk.c | 11 -----------
>  1 file changed, 11 deletions(-)
>

Who doesn't like removal of code?.. :)

Acked-by: Andrii Nakryiko <andriin@...com>

[...]