netdev - Re: [PATCH] ath9k: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190917064100.E72E0613A8@smtp.codeaurora.org>
Date:   Tue, 17 Sep 2019 06:41:00 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>
Cc:     davem@...emloft.net, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ath9k: remove unneeded variable

Ding Xiang <dingxiang@...s.chinamobile.com> wrote:

> "len" is unneeded,just return 0
> 
> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>

ALWAYS build check your patches! I admit that ATH_DUMP_BTCOEX() is an
evil macro as it uses len variable in secret, but if you had compiled
your patch you would have noticed this immeadiately.

In file included from drivers/net/wireless/ath/ath9k/gpio.c:17:
drivers/net/wireless/ath/ath9k/gpio.c: In function 'ath9k_dump_legacy_btcoex':
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: error: 'len' undeclared (first use in this function); did you mean '_end'?
   len += scnprintf(buf + len, size - len,  \
   ^~~
drivers/net/wireless/ath/ath9k/gpio.c:502:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
  ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
  ^~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: note: each undeclared identifier is reported only once for each function it appears in
   len += scnprintf(buf + len, size - len,  \
   ^~~
drivers/net/wireless/ath/ath9k/gpio.c:502:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
  ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
  ^~~~~~~~~~~~~~~
make[5]: *** [drivers/net/wireless/ath/ath9k/gpio.o] Error 1
make[4]: *** [drivers/net/wireless/ath/ath9k] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2

-- 
https://patchwork.kernel.org/patch/11139147/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches