lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Sep 2019 14:41:32 +0200 From: Andrew Lunn <andrew@...n.ch> To: Alexandru Ardelean <alexandru.ardelean@...log.com> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, davem@...emloft.net, robh+dt@...nel.org, peppe.cavallaro@...com, alexandre.torgue@...com, f.fainelli@...il.com Subject: Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type On Tue, Sep 17, 2019 at 01:30:52PM +0300, Alexandru Ardelean wrote: > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > which are enums of mode strings. > > The 'dwmac' driver supports almost all modes declared in the 'phy-mode' > enum (except for 1 or 2). But in general, there may be a case where > 'mac-mode' becomes more generic and is moved as part of phylib or netdev. > > In any case, the 'mac-mode' field should be made an enum, and it also makes > sense to just reference the 'phy-connection-type' from > 'ethernet-controller.yaml'. That will also make it more future-proof for new > modes. > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com> Hi Alexandru Adding a Fixes: tag would be good. Just reply in this thread, and patchwork will do magic to append it to the patch. Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists