netdev - Re: [PATCH net-next] net: ethernet: ti: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Sep 2019 11:35:59 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     YueHaibing <yuehaibing@...wei.com>,
        "David S. Miller" <davem@...emloft.net>,
        ivan.khoronzhuk@...aro.org, Andrew Lunn <andrew@...n.ch>,
        Petr Štetiar <ynezz@...e.cz>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        "open list:TI ETHERNET SWITCH DRIVER (CPSW)" 
        <linux-omap@...r.kernel.org>
Subject: Re: [PATCH net-next] net: ethernet: ti: use devm_platform_ioremap_resource()
 to simplify code

Hi Grygorii,

On Wed, Sep 18, 2019 at 11:29 AM Grygorii Strashko
<grygorii.strashko@...com> wrote:
> On 17/09/2019 21:35, Geert Uytterhoeven wrote:
> > On Wed, Aug 21, 2019 at 2:51 PM YueHaibing <yuehaibing@...wei.com> wrote:
> >> Use devm_platform_ioremap_resource() to simplify the code a bit.
> >> This is detected by coccinelle.
> >>
> >> Reported-by: Hulk Robot <hulkci@...wei.com>
> >> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> >> ---
> >>   drivers/net/ethernet/ti/cpsw.c | 5 ++---
> >>   1 file changed, 2 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> >> index 32a8974..5401095 100644
> >> --- a/drivers/net/ethernet/ti/cpsw.c
> >> +++ b/drivers/net/ethernet/ti/cpsw.c
> >> @@ -2764,7 +2764,7 @@ static int cpsw_probe(struct platform_device *pdev)
> >>          struct net_device               *ndev;
> >>          struct cpsw_priv                *priv;
> >>          void __iomem                    *ss_regs;
> >> -       struct resource                 *res, *ss_res;
> >> +       struct resource                 *ss_res;
> >>          struct gpio_descs               *mode;
> >>          const struct soc_device_attribute *soc;
> >>          struct cpsw_common              *cpsw;
> >> @@ -2798,8 +2798,7 @@ static int cpsw_probe(struct platform_device *pdev)
> >
> > And just out-of-context, we also have:
> >
> >          ss_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >          ss_regs = devm_ioremap_resource(dev, ss_res);
> >          if (IS_ERR(ss_regs))
> >
> > which was not detected as being the same pattern?
> >
> > Interesting...
>
> ss_res is used below to determine phys address of CPPI RAM.

Right, thanks, I missed that.

> >
> >>                  return PTR_ERR(ss_regs);
> >>          cpsw->regs = ss_regs;
> >>
> >> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> >> -       cpsw->wr_regs = devm_ioremap_resource(dev, res);
> >> +       cpsw->wr_regs = devm_platform_ioremap_resource(pdev, 1);
> >>          if (IS_ERR(cpsw->wr_regs))
> >>                  return PTR_ERR(cpsw->wr_regs);

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds