netdev - Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190919.131816.1861650130627229336.davem@davemloft.net>
Date:   Thu, 19 Sep 2019 13:18:16 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     steffen.klassert@...unet.com
Cc:     marcelo.leitner@...il.com, willemdebruijn.kernel@...il.com,
        netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Thu, 19 Sep 2019 13:01:25 +0200

> If the packet data of all the fraglist GRO skbs are backed by a
> page fragment then we could just do the same by iterating with
> skb_walk_frags(). I'm not a driver expert and might be misstaken,
> but it looks like that could be done with existing hardware that
> supports segmentation offload.

Having to add frag list as well as page frag iterating in a driver is
quite a bit of logic, and added complexity.

If the frag list SKBs are indeed backed by a page, you could just as
easily coalesce everything into the page frag array of the first SKB.