netdev - Re: [PATCH RFC] net/phy: fix Marvell PHYs probe failure when HWMON and THERMAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190919135243.GB22556@lunn.ch>
Date:   Thu, 19 Sep 2019 15:52:43 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Peter Mamonov <pmamonov@...il.com>
Cc:     f.fainelli@...il.com, hkallweit1@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH RFC] net/phy: fix Marvell PHYs probe failure when HWMON
 and THERMAL_OF are enabled

On Thu, Sep 19, 2019 at 11:10:56AM +0300, Peter Mamonov wrote:
> Hi, Andrew,
> 
> On Thu, Sep 19, 2019 at 04:50:16AM +0200, Andrew Lunn wrote:
> > On Thu, Sep 19, 2019 at 12:38:37AM +0300, Peter Mamonov wrote:
> > > Hello,
> > > 
> > > Some time ago I've discovered that probe functions of certain Marvell PHYs 
> > > fail if both HWMON and THERMAL_OF config options are enabled.
> > 
> > Hi Peter
> > 
> > It probably affects more then Marvell PHYs.
> > 
> > > The root 
> > > cause of this problem is a lack of an OF node for a PHY's built-in 
> > > temperature sensor.  However I consider adding this OF node to be a bit 
> > > excessive solution. Am I wrong? Below you will find a one line patch which 
> > > fixes the problem.
> > 
> > Your patch look sensible to me.
> > 
> > > I've sent it to the releveant maintainers three weeks 
> > > ago without any feedback yet.
> > 
> > Could you point me at the relevant mailing list archive?
> 
> Here it is: https://marc.info/?l=linux-pm&m=156691695616377&w=2

Hi Peter

O.K. Thanks.

We should not take this patch via netdev, since it is outside of
netdev, even if it does break netdev. So lets polish the patch a bit,
and then repost it to linux-pm and its maintainers.

Please could you add a Fixes: tag. Can you figure out which commit
broke it, or has it always been broken?

Add a stable: tag, indicating it needs to be back ported. For netdev,
you would not do this, but for linux-pm, i guess it is needed.

Change the subject a little. thermal: Fix broken registration if sensor OF node missing.

Add

Reviewed-by: Andrew Lunn <andrew@...n.ch>

When you post it, please Cc: me, netdev, davem, but make the To: the
three thermal maintainers.

Thanks
      Andrew