netdev - Re: [PATCH] dimlib: make DIMLIB a hidden symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <670cc72f-fef0-a8cf-eb03-25fdb608eea8@mellanox.com>
Date:   Fri, 20 Sep 2019 17:02:10 +0000
From:   Tal Gilboa <talgi@...lanox.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Arthur Kiyanovski <akiyano@...zon.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] dimlib: make DIMLIB a hidden symbol

On 9/20/2019 4:31 PM, Uwe Kleine-König wrote:
> According to Tal Gilboa the only benefit from DIM comes from a driver
> that uses it. So it doesn't make sense to make this symbol user visible,
> instead all drivers that use it should select it (as is already the case
> AFAICT).
> 
> Signed-off-by: Uwe Kleine-König <uwe@...ine-koenig.org>
> ---
>   lib/Kconfig | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index cc04124ed8f7..9fe8a21fd183 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -555,8 +555,7 @@ config SIGNATURE
>   	  Implementation is done using GnuPG MPI library
>   
>   config DIMLIB
> -	bool "DIM library"
> -	default y
> +	bool
>   	help
>   	  Dynamic Interrupt Moderation library.
>   	  Implements an algorithm for dynamically change CQ moderation values
>
There's a pending series using DIM which didn't add the select clause 
[1]. Arthur, FYI. Other than that LGTM.

[1] https://www.mail-archive.com/netdev@vger.kernel.org/msg314304.html