netdev - Re: [PATCH -next] treewide: remove unused argument in lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Sep 2019 08:50:36 -0400
From:   Qian Cai <cai@....pw>
To:     Will Deacon <will@...nel.org>, torvalds@...ux-foundation.org
Cc:     ast@...nel.org, akpm@...ux-foundation.org, mingo@...hat.com,
        peterz@...radead.org, linux-kernel@...r.kernel.org,
        linux-api@...r.kernel.org, maarten.lankhorst@...ux.intel.com,
        mripard@...nel.org, sean@...rly.run, airlied@...ux.ie,
        daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        gregkh@...uxfoundation.org, jslaby@...e.com,
        viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        intel-gfx@...ts.freedesktop.org, tytso@....edu, jack@...e.com,
        linux-ext4@...r.kernel.org, tj@...nel.org, mark@...heh.com,
        jlbec@...lplan.org, joseph.qi@...ux.alibaba.com,
        ocfs2-devel@....oracle.com, davem@...emloft.net,
        daniel@...earbox.net, netdev@...r.kernel.org, bpf@...r.kernel.org,
        duyuyang@...il.com, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, hannes@...xchg.org, mhocko@...nel.org,
        vdavydov.dev@...il.com, cgroups@...r.kernel.org,
        linux-mm@...ck.org, alexander.levin@...rosoft.com
Subject: Re: [PATCH -next] treewide: remove unused argument in lock_release()

On Fri, 2019-09-20 at 10:38 +0100, Will Deacon wrote:
> On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote:
> > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument
> > in __lock_release"), @nested is no longer used in lock_release(), so
> > remove it from all lock_release() calls and friends.
> > 
> > Signed-off-by: Qian Cai <cai@....pw>
> > ---
> 
> Although this looks fine to me at a first glance, it might be slightly
> easier to manage if you hit {spin,rwlock,seqcount,mutex,rwsem}_release()
> first with coccinelle scripts, and then hack lock_release() as a final
> patch. That way it's easy to regenerate things if needed.

I am not sure if it worth the extra efforts where I have to retest it on all
architectures, and the patch is really simple, but I can certainly do that if
you insist.

I have just confirmed the patch [1] also applied correctly to the latest
mainline, so it might be the best time just for Linus to merge it directly so it
does not introduce build errors later on?

[1]

https://lore.kernel.org/lkml/1568909380-32199-1-git-send-email-cai@lca.pw/