lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Sep 2019 18:05:26 -0700 From: Cong Wang <xiyou.wangcong@...il.com> To: Vlad Buslov <vladbu@...lanox.com> Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>, Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>, David Miller <davem@...emloft.net> Subject: Re: [PATCH net v2 1/3] net: sched: sch_htb: don't call qdisc_put() while holding tree lock On Thu, Sep 19, 2019 at 1:14 PM Vlad Buslov <vladbu@...lanox.com> wrote: > Notes: > Changes V1 -> V2: > > - Extend sch API with new qdisc_put_empty() function that has same > implementation as regular qdisc_put() but skips parts that reset qdisc > and free all packet buffers from gso_skb and skb_bad_txq queues. I don't understand why you need a new API here, as long as qdisc_reset() gets called before releasing sch tree lock, the ->reset() inside qdisc_put(), after releasing sch tree lock, should be a nop, right?
Powered by blists - more mailing lists