netdev - Re: [PATCH 4/5] ieee802154: enforce CAP_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Sep 2019 14:30:58 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Stefan Schmidt <stefan@...enfreihafen.org>
Cc:     netdev@...r.kernel.org, isdn@...ux-pingi.de, jreuter@...na.de,
        ralf@...ux-mips.org, alex.aring@...il.com, orinimron123@...il.com
Subject: Re: [PATCH 4/5] ieee802154: enforce CAP_NET_RAW for raw sockets

On Sat, Sep 21, 2019 at 01:58:55PM +0200, Stefan Schmidt wrote:
> Hello.
> 
> On 20.09.19 09:35, Greg Kroah-Hartman wrote:
> > From: Ori Nimron <orinimron123@...il.com>
> > 
> > When creating a raw AF_IEEE802154 socket, CAP_NET_RAW needs to be
> > checked first.
> > 
> > Signed-off-by: Ori Nimron <orinimron123@...il.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  net/ieee802154/socket.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
> > index badc5cfe4dc6..d93d4531aa9b 100644
> > --- a/net/ieee802154/socket.c
> > +++ b/net/ieee802154/socket.c
> > @@ -1008,6 +1008,9 @@ static int ieee802154_create(struct net *net, struct socket *sock,
> >  
> >  	switch (sock->type) {
> >  	case SOCK_RAW:
> > +		rc = -EPERM;
> > +		if (!capable(CAP_NET_RAW))
> > +			goto out;
> >  		proto = &ieee802154_raw_prot;
> >  		ops = &ieee802154_raw_ops;
> >  		break;
> > 
> 
> I assume this will go as a whole series into net. If you want me to pick
> it up into my tree directly let me know.
> 
> Acked-by: Stefan Schmidt <stefan@...enfreihafen.org>

That's up to the networking maintainer, if he does not suck it in, I'll
resend and ask you to take it.

thanks,

greg k-h