netdev - [next] regression: WiFi doesn't work after "nl80211: Add support for EDMG channels"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e82fa5e1-c6a3-e4c4-92b0-64cc8285b825@gmail.com>
Date:   Sat, 21 Sep 2019 20:12:39 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Johannes Berg <johannes@...solutions.net>,
        Alexei Avshalom Lazar <ailizaro@...eaurora.org>,
        Kalle Valo <kvalo@...eaurora.org>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: [next] regression: WiFi doesn't work after "nl80211: Add support for
 EDMG channels"

Hello,

Patch "nl80211: Add support for EDMG channels" broke brcmfmac driver on one of my devices, the newly
introduced cfg80211_chandef_is_edmg() erroneously returns "true" because chandef->edmg.bw_config !=
NULL. Apparently this happens because "chandef" is allocated on stack in nl80211.c (and other places),
the "edmg" field isn't zeroed while it should be. Please fix, thanks in advance.

WARNING: CPU: 0 PID: 409 at net/wireless/nl80211.c:3118 nl80211_send_chandef+0xd3/0xd8
Modules linked in:
CPU: 0 PID: 409 Comm: NetworkManager Tainted: G        W
5.3.0-next-20190920-00177-g89b36954c24f #2381
Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
(show_stack+0x11/0x14)
(dump_stack+0x7f/0x8c)
(__warn+0xc1/0xc4)
(warn_slowpath_fmt+0x45/0x78)
(nl80211_send_chandef+0xd3/0xd8)
(nl80211_send_iface+0x4db/0x6a0)
(nl80211_get_interface+0x39/0x68)
(genl_rcv_msg+0x14d/0x33c)
(netlink_rcv_skb+0x85/0xb8)
(genl_rcv+0x21/0x30)
(netlink_unicast+0xf3/0x144)
(netlink_sendmsg+0x12b/0x27c)
(sock_sendmsg+0x11/0x1c)
(___sys_sendmsg+0x1bb/0x1d0)
(__sys_sendmsg+0x39/0x58)
(ret_fast_syscall+0x1/0x28)
Exception stack(0xe1621fa8 to 0xe1621ff0)
1fa0:                   00000000 bea1b830 00000009 bea1b830 00000000 00000000
1fc0: 00000000 bea1b830 00000009 00000128 00644084 b6fd6930 00683d30 00645330
1fe0: 00000128 bea1b808 b6a1b3a5 b6a1c6b6