lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Sep 2019 19:49:46 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Arnd Bergmann <arnd@...db.de> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [v2] net: stmmac: selftest: avoid large stack usage On Thu, 19 Sep 2019 14:33:43 +0200, Arnd Bergmann wrote: > Putting a struct stmmac_rss object on the stack is a bad idea, > as it exceeds the warning limit for a stack frame on 32-bit architectures: > > drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c:1221:12: error: stack frame size of 1208 bytes in function '__stmmac_test_l3filt' [-Werror,-Wframe-larger-than=] > drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c:1338:12: error: stack frame size of 1208 bytes in function '__stmmac_test_l4filt' [-Werror,-Wframe-larger-than=] > > As the object is the trivial empty case, change the called function > to accept a NULL pointer to mean the same thing and remove the > large variable in the two callers. > > Fixes: 4647e021193d ("net: stmmac: selftests: Add selftest for L3/L4 Filters") > Signed-off-by: Arnd Bergmann <arnd@...db.de> Applied, thank you!
Powered by blists - more mailing lists