lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Sep 2019 20:07:41 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Mao Wenan <maowenan@...wei.com> Cc: <netanel@...zon.com>, <saeedb@...zon.com>, <zorik@...zon.com>, <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>, Uwe Kleine-König <uwe@...ine-koenig.org> Subject: Re: [PATCH net] net: ena: Add dependency for ENA_ETHERNET On Fri, 20 Sep 2019 16:44:05 +0800, Mao Wenan wrote: > If CONFIG_ENA_ETHERNET=y and CONFIG_DIMLIB=n, > below erros can be found: > drivers/net/ethernet/amazon/ena/ena_netdev.o: In function `ena_dim_work': > ena_netdev.c:(.text+0x21cc): undefined reference to `net_dim_get_rx_moderation' > ena_netdev.c:(.text+0x21cc): relocation truncated to > fit: R_AARCH64_CALL26 against undefined symbol `net_dim_get_rx_moderation' > drivers/net/ethernet/amazon/ena/ena_netdev.o: In function `ena_io_poll': > ena_netdev.c:(.text+0x7bd4): undefined reference to `net_dim' > ena_netdev.c:(.text+0x7bd4): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `net_dim' > > After commit 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive > interrupt moderation"), it introduces dim algorithm, which configured by CONFIG_DIMLIB. > > Fixes: 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive interrupt moderation") > Signed-off-by: Mao Wenan <maowenan@...wei.com> Thank you Mao, shortly after you posted your patch Uwe proposed to make DIMLIB a hidden symbol: https://lore.kernel.org/netdev/a85be675-ce56-f7ba-29e9-b749073aab6c@kleine-koenig.org/T/#t That patch will likely be applied soon, could you please rework your patch to use the "select" keyword instead of "depends". That's what other users do. > diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig > index 69ca99d..fe46df4 100644 > --- a/drivers/net/ethernet/amazon/Kconfig > +++ b/drivers/net/ethernet/amazon/Kconfig > @@ -18,7 +18,7 @@ if NET_VENDOR_AMAZON > > config ENA_ETHERNET > tristate "Elastic Network Adapter (ENA) support" > - depends on PCI_MSI && !CPU_BIG_ENDIAN > + depends on PCI_MSI && !CPU_BIG_ENDIAN && DIMLIB > ---help--- > This driver supports Elastic Network Adapter (ENA)" >
Powered by blists - more mailing lists