netdev - Re: [PATCH net v3 00/11] net: fix nested device bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMArcTUm6opp1J2pAhshhJvUYkqM15REhem_Dw+Fyu9m17rDXA@mail.gmail.com>
Date:   Sun, 22 Sep 2019 23:36:00 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, j.vosburgh@...il.com,
        vfalico@...il.com, Andy Gospodarek <andy@...yhouse.net>,
        Jiří Pírko <jiri@...nulli.us>,
        sd@...asysnail.net, Roopa Prabhu <roopa@...ulusnetworks.com>,
        saeedm@...lanox.com, manishc@...vell.com, rahulv@...vell.com,
        kys@...rosoft.com, haiyangz@...rosoft.com,
        Stephen Hemminger <stephen@...workplumber.org>,
        sashal@...nel.org, hare@...e.de, varun@...lsio.com,
        ubraun@...ux.ibm.com, kgraul@...ux.ibm.com,
        Jay Vosburgh <jay.vosburgh@...onical.com>
Subject: Re: [PATCH net v3 00/11] net: fix nested device bugs

On Sat, 21 Sep 2019 at 08:59, Jakub Kicinski
<jakub.kicinski@...ronome.com> wrote:
>
> On Mon, 16 Sep 2019 22:47:51 +0900, Taehee Yoo wrote:
> > This patchset fixes several bugs that are related to nesting
> > device infrastructure.
> > Current nesting infrastructure code doesn't limit the depth level of
> > devices. nested devices could be handled recursively. at that moment,
> > it needs huge memory and stack overflow could occur.
> > Below devices type have same bug.
> > VLAN, BONDING, TEAM, MACSEC, MACVLAN and VXLAN.
>
> Is this list exhaustive? Looks like qmi_wwan.c perhaps could also have
> similar problem? Or virt_wifi? Perhaps worth CCing the authors of those
> drivers and mentioning that?
>
> Thank you for working on this!

I couldn't test all interface types.
So there could be more interface types that have a similar problem.
I will send a v4 patch and add more authors to the CC list.

Thank you so much for your review again!