lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Sep 2019 11:21:24 -0700 From: Shannon Nelson <snelson@...sando.io> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Pensando Drivers <drivers@...sando.io>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH net] ionic: Fix an error code in ionic_lif_alloc() On 9/20/19 10:59 PM, Dan Carpenter wrote: > We need to set the error code on this path. Otherwise it probably > results in a NULL dereference down the line. > > Fixes: aa3198819bea ("ionic: Add RSS support") > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> > --- > drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c > index db7c82742828..72107a0627a9 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c > @@ -1704,6 +1704,7 @@ static struct ionic_lif *ionic_lif_alloc(struct ionic *ionic, unsigned int index > GFP_KERNEL); > > if (!lif->rss_ind_tbl) { > + err = -ENOMEM; > dev_err(dev, "Failed to allocate rss indirection table, aborting\n"); > goto err_out_free_qcqs; > } Thanks, Dan. Acked-by: Shannon Nelson <snelson@...sando.io>
Powered by blists - more mailing lists