netdev - Re: [PATCH] dimlib: make DIMLIB a hidden symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9cad4ba-288e-2e01-3fba-3fb3e2a52aac@kleine-koenig.org>
Date:   Mon, 23 Sep 2019 08:18:29 +0200
From:   Uwe Kleine-König <uwe@...ine-koenig.org>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Tal Gilboa <talgi@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] dimlib: make DIMLIB a hidden symbol

Hello Jakub,

On 9/22/19 5:06 AM, Jakub Kicinski wrote:
> On Fri, 20 Sep 2019 15:31:15 +0200, Uwe Kleine-König wrote:
>> According to Tal Gilboa the only benefit from DIM comes from a driver
>> that uses it. So it doesn't make sense to make this symbol user visible,
>> instead all drivers that use it should select it (as is already the case
>> AFAICT).
>>
>> Signed-off-by: Uwe Kleine-König <uwe@...ine-koenig.org>
>> ---
>>  lib/Kconfig | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index cc04124ed8f7..9fe8a21fd183 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -555,8 +555,7 @@ config SIGNATURE
>>  	  Implementation is done using GnuPG MPI library
>>  
>>  config DIMLIB
>> -	bool "DIM library"
>> -	default y
>> +	bool
>>  	help
>>  	  Dynamic Interrupt Moderation library.
>>  	  Implements an algorithm for dynamically change CQ moderation values
> 
> Hi Uwe! Looks like in the net tree there is a spelling mistake and
> moderation is spelled "modertion":
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/tree/lib/Kconfig#n562
> 
> I'm not seeing any patch to fix that anywhere, is it possible you have
> some local change in your tree?

I sent a patch[1] for that typo, but at that time wasn't aware that
DIMLIB was relevant for net and so didn't Cc the netdev.

Best regards
Uwe

[1]
https://lore.kernel.org/lkml/20190919210314.22110-1-uwe@kleine-koenig.org/



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)