netdev - Re: [PATCH] net-icmp: remove ping_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190924.213352.2279175030201650840.davem@davemloft.net>
Date:   Tue, 24 Sep 2019 21:33:52 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     zenczykowski@...il.com
Cc:     netdev@...r.kernel.org, keescook@...gle.com, dvyukov@...gle.com,
        edumazet@...gle.com, maheshb@...gle.com, lorenzo@...gle.com
Subject: Re: [PATCH] net-icmp: remove ping_group_range sysctl

From: Maciej Żenczykowski <zenczykowski@...il.com>
Date: Tue, 24 Sep 2019 16:47:00 +0200

>> Removing this is going to break things, you can't just remove a sysctl
>> because "oh it was a bad idea to add this, sorry."
> 
> Yeah, I know... but do you have any other suggestions?
> 
> Would you take an alternative to make the default wide opened?

This also could break things.

The horse has left the barn on this one.

> Perhaps having it as a non-namespace aware global setting (with a
> default of on) would be more palatable?

Also could break things.

You're going to have to change this in a way such that the administrator
has to explicitly ask for the new behavior.