lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Sep 2019 21:45:08 +0200 (CEST) From: David Miller <davem@...emloft.net> To: thierry.reding@...il.com Cc: peppe.cavallaro@...com, alexandre.torgue@...com, joabreu@...opsys.com, f.fainelli@...il.com, jonathanh@...dia.com, bbiswas@...dia.com, netdev@...r.kernel.org, linux-tegra@...r.kernel.org Subject: Re: [PATCH v3 0/2] net: stmmac: Enhanced addressing mode for DWMAC 4.10 From: Thierry Reding <thierry.reding@...il.com> Date: Fri, 20 Sep 2019 19:00:34 +0200 > From: Thierry Reding <treding@...dia.com> > > The DWMAC 4.10 supports the same enhanced addressing mode as later > generations. Parse this capability from the hardware feature registers > and set the EAME (Enhanced Addressing Mode Enable) bit when necessary. This looks like an enhancement and/or optimization rather than a bug fix. Also, you're now writing to the high 32-bits unconditionally, even when it will always be zero because of 32-bit addressing. That looks like a step backwards to me. I'm not applying this.
Powered by blists - more mailing lists