netdev - Re: [PATCH net v2] net/sched: cbs: Fix not adding cbs instance to list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wodyfgnv.fsf@intel.com>
Date:   Mon, 23 Sep 2019 21:43:16 -0700
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net v2] net/sched: cbs: Fix not adding cbs instance to list

Hi,

Cong Wang <xiyou.wangcong@...il.com> writes:

> On Mon, Sep 23, 2019 at 5:14 PM Vinicius Costa Gomes
> <vinicius.gomes@...el.com> wrote:
>> @@ -417,12 +421,6 @@ static int cbs_init(struct Qdisc *sch, struct nlattr *opt,
>>         if (err)
>>                 return err;
>>
>> -       if (!q->offload) {
>> -               spin_lock(&cbs_list_lock);
>> -               list_add(&q->cbs_list, &cbs_list);
>> -               spin_unlock(&cbs_list_lock);
>> -       }
>> -
>>         return 0;
>
> These two return's now can be folded into one, right?

Yeah, good catch. Will fix.


Cheers,
--
Vinicius