netdev - Re: [PATCH] net: dsa: microchip: Always set regmap stride to 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1d256eb-85d0-4bdc-e49a-1ec00d2a2cb7@denx.de>
Date:   Thu, 26 Sep 2019 00:09:06 +0200
From:   Marek Vasut <marex@...x.de>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
        george.mccollister@...il.com, Tristram.Ha@...rochip.com,
        vivien.didelot@...oirfairelinux.com, woojung.huh@...rochip.com
Subject: Re: [PATCH] net: dsa: microchip: Always set regmap stride to 1

On 9/25/19 1:44 PM, David Miller wrote:
> From: Marek Vasut <marex@...x.de>
> Date: Sat, 21 Sep 2019 19:53:09 +0200
> 
>> The regmap stride is set to 1 for regmap describing 8bit registers already.
>> However, for 16/32/64bit registers, the stride is 2/4/8 respectively. This
>> is not correct, as the switch protocol supports unaligned register reads
>> and writes and the KSZ87xx even uses such unaligned register accesses to
>> read e.g. MIB counter.
>>
>> This patch fixes MIB counter access on KSZ87xx.
>>
>> Signed-off-by: Marek Vasut <marex@...x.de>
> 
> Please resubmit with an appropriate Fixes: tag as per Florian's feedback.

Done