lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Sep 2019 20:09:07 -0500 From: Navid Emamdoost <navid.emamdoost@...il.com> To: unlisted-recipients:; (no To-header on input) Cc: emamd001@....edu, smccaman@....edu, kjlu@....edu, Navid Emamdoost <navid.emamdoost@...il.com>, Johannes Berg <johannes.berg@...el.com>, Emmanuel Grumbach <emmanuel.grumbach@...el.com>, Luca Coelho <luciano.coelho@...el.com>, Intel Linux Wireless <linuxwifi@...el.com>, Kalle Valo <kvalo@...eaurora.org>, "David S. Miller" <davem@...emloft.net>, Shahar S Matityahu <shahar.s.matityahu@...el.com>, Sara Sharon <sara.sharon@...el.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] iwlwifi: prevent memory leak In alloc_sgtable if alloc_page fails, along with releasing previously allocated pages, the allocated table should be released too. Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com> --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index 5c8602de9168..87421807e040 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -646,6 +646,7 @@ static struct scatterlist *alloc_sgtable(int size) if (new_page) __free_page(new_page); } + kfree(table); return NULL; } alloc_size = min_t(int, size, PAGE_SIZE); -- 2.17.1
Powered by blists - more mailing lists