netdev - Re: [PATCH net-next] net: core: dev: replace state xoff flag comparison by netif_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190925.135618.473594014346335536.davem@davemloft.net>
Date:   Wed, 25 Sep 2019 13:56:18 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     jcfaracco@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: core: dev: replace state xoff flag
 comparison by netif_xmit_stopped method

From: jcfaracco@...il.com
Date: Sun, 22 Sep 2019 22:57:29 -0300

> From: Julio Faracco <jcfaracco@...il.com>
> 
> Function netif_schedule_queue() has a hardcoded comparison between queue
> state and any xoff flag. This comparison does the same thing as method
> netif_xmit_stopped(). In terms of code clarity, it is better. See other
> methods like: generic_xdp_tx() and dev_direct_xmit().
> 
> Signed-off-by: Julio Faracco <jcfaracco@...il.com>

net-next is closed, please resubmit when the net-next tree opens back up.

Thank you.