lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Sep 2019 11:57:59 +0000 From: Igor Russkikh <Igor.Russkikh@...antia.com> To: Dan Carpenter <dan.carpenter@...cle.com>, David VomLehn <vomlehn@...as.net> CC: "David S. Miller" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH net] net: aquantia: Fix aq_vec_isr_legacy() return value On 25.09.2019 13:54, Dan Carpenter wrote: > The irqreturn_t type is an enum or an unsigned int in GCC. That > creates to problems because it can't detect if the > self->aq_hw_ops->hw_irq_read() call fails and at the end the function > always returns IRQ_HANDLED. Thanks for noticing this, Dan! > drivers/net/ethernet/aquantia/atlantic/aq_vec.c:316 aq_vec_isr_legacy() warn: unsigned 'err' is never less than zero. > drivers/net/ethernet/aquantia/atlantic/aq_vec.c:329 aq_vec_isr_legacy() warn: always true condition '(err >= 0) => (0-u32max >= 0)' > > Fixes: 970a2e9864b0 ("net: ethernet: aquantia: Vector operations") > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Reviewed-by: Igor Russkikh <igor.russkikh@...antia.com> Regards, Igor
Powered by blists - more mailing lists