lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Sep 2019 20:13:54 +0800 From: Jason Wang <jasowang@...hat.com> To: "Tian, Kevin" <kevin.tian@...el.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>, "intel-gvt-dev@...ts.freedesktop.org" <intel-gvt-dev@...ts.freedesktop.org>, "kwankhede@...dia.com" <kwankhede@...dia.com>, "alex.williamson@...hat.com" <alex.williamson@...hat.com>, "mst@...hat.com" <mst@...hat.com>, "Bie, Tiwei" <tiwei.bie@...el.com> Cc: "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "cohuck@...hat.com" <cohuck@...hat.com>, "maxime.coquelin@...hat.com" <maxime.coquelin@...hat.com>, "Liang, Cunming" <cunming.liang@...el.com>, "Wang, Zhihong" <zhihong.wang@...el.com>, "rob.miller@...adcom.com" <rob.miller@...adcom.com>, "Wang, Xiao W" <xiao.w.wang@...el.com>, "haotian.wang@...ive.com" <haotian.wang@...ive.com>, "zhenyuw@...ux.intel.com" <zhenyuw@...ux.intel.com>, "Wang, Zhi A" <zhi.a.wang@...el.com>, "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>, "joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>, "Vivi, Rodrigo" <rodrigo.vivi@...el.com>, "airlied@...ux.ie" <airlied@...ux.ie>, "daniel@...ll.ch" <daniel@...ll.ch>, "farman@...ux.ibm.com" <farman@...ux.ibm.com>, "pasic@...ux.ibm.com" <pasic@...ux.ibm.com>, "sebott@...ux.ibm.com" <sebott@...ux.ibm.com>, "oberpar@...ux.ibm.com" <oberpar@...ux.ibm.com>, "heiko.carstens@...ibm.com" <heiko.carstens@...ibm.com>, "gor@...ux.ibm.com" <gor@...ux.ibm.com>, "borntraeger@...ibm.com" <borntraeger@...ibm.com>, "akrowiak@...ux.ibm.com" <akrowiak@...ux.ibm.com>, "freude@...ux.ibm.com" <freude@...ux.ibm.com>, "Zhu, Lingshan" <lingshan.zhu@...el.com>, "idos@...lanox.com" <idos@...lanox.com>, "eperezma@...hat.com" <eperezma@...hat.com>, "lulu@...hat.com" <lulu@...hat.com>, "parav@...lanox.com" <parav@...lanox.com>, "christophe.de.dinechin@...il.com" <christophe.de.dinechin@...il.com> Subject: Re: [PATCH V2 2/8] mdev: class id support On 2019/9/25 下午4:28, Tian, Kevin wrote: >> From: Jason Wang >> Sent: Tuesday, September 24, 2019 9:53 PM >> >> Mdev bus only supports vfio driver right now, so it doesn't implement >> match method. But in the future, we may add drivers other than vfio, >> the first driver could be virtio-mdev. This means we need to add >> device class id support in bus match method to pair the mdev device >> and mdev driver correctly. >> >> So this patch adds id_table to mdev_driver and class_id for mdev >> parent with the match method for mdev bus. >> >> Signed-off-by: Jason Wang <jasowang@...hat.com> >> --- >> Documentation/driver-api/vfio-mediated-device.rst | 3 +++ >> drivers/gpu/drm/i915/gvt/kvmgt.c | 1 + >> drivers/s390/cio/vfio_ccw_ops.c | 1 + >> drivers/s390/crypto/vfio_ap_ops.c | 1 + >> drivers/vfio/mdev/mdev_core.c | 7 +++++++ >> drivers/vfio/mdev/mdev_driver.c | 14 ++++++++++++++ >> drivers/vfio/mdev/mdev_private.h | 1 + >> drivers/vfio/mdev/vfio_mdev.c | 6 ++++++ >> include/linux/mdev.h | 8 ++++++++ >> include/linux/mod_devicetable.h | 8 ++++++++ >> samples/vfio-mdev/mbochs.c | 1 + >> samples/vfio-mdev/mdpy.c | 1 + >> samples/vfio-mdev/mtty.c | 1 + >> 13 files changed, 53 insertions(+) >> >> diff --git a/Documentation/driver-api/vfio-mediated-device.rst >> b/Documentation/driver-api/vfio-mediated-device.rst >> index 25eb7d5b834b..a5bdc60d62a1 100644 >> --- a/Documentation/driver-api/vfio-mediated-device.rst >> +++ b/Documentation/driver-api/vfio-mediated-device.rst >> @@ -102,12 +102,14 @@ structure to represent a mediated device's >> driver:: >> * @probe: called when new device created >> * @remove: called when device removed >> * @driver: device driver structure >> + * @id_table: the ids serviced by this driver >> */ >> struct mdev_driver { >> const char *name; >> int (*probe) (struct device *dev); >> void (*remove) (struct device *dev); >> struct device_driver driver; >> + const struct mdev_class_id *id_table; >> }; >> >> A mediated bus driver for mdev should use this structure in the function >> calls >> @@ -165,6 +167,7 @@ register itself with the mdev core driver:: >> extern int mdev_register_device(struct device *dev, >> const struct mdev_parent_ops *ops); >> >> + >> However, the mdev_parent_ops structure is not required in the function >> call >> that a driver should use to unregister itself with the mdev core driver:: >> >> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c >> b/drivers/gpu/drm/i915/gvt/kvmgt.c >> index 23aa3e50cbf8..f793252a3d2a 100644 >> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c >> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c >> @@ -678,6 +678,7 @@ static int intel_vgpu_create(struct kobject *kobj, >> struct mdev_device *mdev) >> dev_name(mdev_dev(mdev))); >> ret = 0; >> >> + mdev_set_class_id(mdev, MDEV_ID_VFIO); >> out: >> return ret; >> } >> diff --git a/drivers/s390/cio/vfio_ccw_ops.c >> b/drivers/s390/cio/vfio_ccw_ops.c >> index f0d71ab77c50..d258ef1fedb9 100644 >> --- a/drivers/s390/cio/vfio_ccw_ops.c >> +++ b/drivers/s390/cio/vfio_ccw_ops.c >> @@ -129,6 +129,7 @@ static int vfio_ccw_mdev_create(struct kobject >> *kobj, struct mdev_device *mdev) >> private->sch->schid.ssid, >> private->sch->schid.sch_no); >> >> + mdev_set_class_id(mdev, MDEV_ID_VFIO); >> return 0; >> } >> >> diff --git a/drivers/s390/crypto/vfio_ap_ops.c >> b/drivers/s390/crypto/vfio_ap_ops.c >> index 5c0f53c6dde7..2cfd96112aa0 100644 >> --- a/drivers/s390/crypto/vfio_ap_ops.c >> +++ b/drivers/s390/crypto/vfio_ap_ops.c >> @@ -343,6 +343,7 @@ static int vfio_ap_mdev_create(struct kobject *kobj, >> struct mdev_device *mdev) >> list_add(&matrix_mdev->node, &matrix_dev->mdev_list); >> mutex_unlock(&matrix_dev->lock); >> >> + mdev_set_class_id(mdev, MDEV_ID_VFIO); >> return 0; >> } >> >> diff --git a/drivers/vfio/mdev/mdev_core.c >> b/drivers/vfio/mdev/mdev_core.c >> index b558d4cfd082..8764cf4a276d 100644 >> --- a/drivers/vfio/mdev/mdev_core.c >> +++ b/drivers/vfio/mdev/mdev_core.c >> @@ -45,6 +45,12 @@ void mdev_set_drvdata(struct mdev_device *mdev, >> void *data) >> } >> EXPORT_SYMBOL(mdev_set_drvdata); >> >> +void mdev_set_class_id(struct mdev_device *mdev, u16 id) >> +{ >> + mdev->class_id = id; >> +} >> +EXPORT_SYMBOL(mdev_set_class_id); >> + >> struct device *mdev_dev(struct mdev_device *mdev) >> { >> return &mdev->dev; >> @@ -135,6 +141,7 @@ static int mdev_device_remove_cb(struct device >> *dev, void *data) >> * mdev_register_device : Register a device >> * @dev: device structure representing parent device. >> * @ops: Parent device operation structure to be registered. >> + * @id: device id. > class id. Right, will fix. Thanks
Powered by blists - more mailing lists