netdev - Re: [PATCH iproute2(-next) 1/1] ip: fix ip route show json output for multipath nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdc66f22-9403-c0fb-196a-360f212cd854@gmail.com>
Date:   Thu, 26 Sep 2019 08:58:42 -0600
From:   David Ahern <dsahern@...il.com>
To:     Julien Fortin <julien@...ulusnetworks.com>, netdev@...r.kernel.org
Cc:     roopa@...ulusnetworks.com
Subject: Re: [PATCH iproute2(-next) 1/1] ip: fix ip route show json output for
 multipath nexthops

On 9/24/19 4:32 PM, Julien Fortin wrote:
> diff --git a/ip/iproute.c b/ip/iproute.c
> index a4533851..5d5f1551 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -649,23 +649,27 @@ static void print_rta_multipath(FILE *fp, const struct rtmsg *r,
>  	int len = RTA_PAYLOAD(rta);
>  	int first = 1;
>  
> +	open_json_array(PRINT_JSON, "nexthops");
> +
>  	while (len >= sizeof(*nh)) {
>  		struct rtattr *tb[RTA_MAX + 1];
>  
>  		if (nh->rtnh_len > len)
>  			break;
>  
> +		open_json_object(NULL);
> +
>  		if (!is_json_context()) {

With the fprintf removed in favor of print_string(PRINT_FP), you should
be able to remove this is_json_context() check and remove a level of
indentation for this section.

>  			if ((r->rtm_flags & RTM_F_CLONED) &&
>  			    r->rtm_type == RTN_MULTICAST) {
>  				if (first) {
> -					fprintf(fp, "Oifs: ");
> +					print_string(PRINT_FP, NULL, "Oifs: ", NULL);
>  					first = 0;
>  				} else {
> -					fprintf(fp, " ");
> +					print_string(PRINT_FP, NULL, " ", NULL);
>  				}
>  			} else
> -				fprintf(fp, "%s\tnexthop ", _SL_);
> +				print_string(PRINT_FP, NULL, "%s\tnexthop ", _SL_);
>  		}
>  
>  		if (nh->rtnh_len > sizeof(*nh)) {