netdev - RE: [RFC 04/20] RDMA/irdma: Add driver framework definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9DD61F30A802C4429A01CA4200E302A7AC702AF5@fmsmsx123.amr.corp.intel.com>
Date:   Thu, 26 Sep 2019 18:10:40 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Jason Gunthorpe <jgg@...lanox.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [RFC 04/20] RDMA/irdma: Add driver framework definitions

> Subject: Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions
> 
> On Thu, Sep 26, 2019 at 08:02:15PM +0200, gregkh@...uxfoundation.org wrote:
> > On Thu, Sep 26, 2019 at 04:55:12PM +0000, Jason Gunthorpe wrote:
> > > On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote:
> > > > +int i40iw_probe(struct platform_device *pdev) {
> > > > +	struct i40e_peer_dev_platform_data *pdata =
> > > > +		dev_get_platdata(&pdev->dev);
> > > > +	struct i40e_info *ldev;
> > >
> > > I thought Greg already said not to use platform_device for this?
> >
> > Yes I did, which is what I thought this whole "use MFD" was supposed
> > to solve.  Why is a platform device still being used here?
> 
> Looks like when mfd creates the 'multi' devices it creates them as
> platform_devices
> 
> /*
>  * Given a platform device that's been created by mfd_add_devices(), fetch
>  * the mfd_cell that created it.
>  */
> static inline const struct mfd_cell *mfd_get_cell(struct platform_device *pdev)
> 
> Jason

That's right. We used the MFD framework. mfd_add_devices() registers the child devices
as platform devs. And the function drivers probe() will get a platform dev.

Shiraz