netdev - Re: [PATCH v2] dimlib: make DIMLIB a hidden symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <979eebb6-1cd5-2d11-3797-b47700c5d454@infradead.org>
Date:   Wed, 25 Sep 2019 17:18:42 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Tal Gilboa <talgi@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2] dimlib: make DIMLIB a hidden symbol

On 9/24/19 9:02 AM, Uwe Kleine-König wrote:
> According to Tal Gilboa the only benefit from DIM comes from a driver
> that uses it. So it doesn't make sense to make this symbol user visible,
> instead all drivers that use it should select it (as is already the case
> AFAICT).
> 
> Signed-off-by: Uwe Kleine-König <uwe@...ine-koenig.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.

> ---
> Hello David,
> 
> On Tue, Sep 24, 2019 at 04:45:28PM +0200, David Miller wrote:
>> Since this doesn't apply due to the moderation typo being elsewhere, I'd
>> really like you to fix up this submission to properly be against 'net'.
> 
> I thought it would be possible to git-apply my patch with the -3 option.
> I even tested that, but obviously it only applies to my tree that has
> the git object with the typo fixed. Sorry for the extra effort I'm
> forcing on you. This patch applies to your public tree from just now.
> 
> Best regads
> Uwe
> 
>  lib/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 4e6b1c3e4c98..d7fc9eb33b9b 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -555,8 +555,7 @@ config SIGNATURE
>  	  Implementation is done using GnuPG MPI library
>  
>  config DIMLIB
> -	bool "DIM library"
> -	default y
> +	bool
>  	help
>  	  Dynamic Interrupt Moderation library.
>  	  Implements an algorithm for dynamically change CQ modertion values
> 


-- 
~Randy