netdev - Re: [PATCH net] net: socionext: Fix a signedness bug in ave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190926152831.DDD6.4A936039@socionext.com>
Date:   Thu, 26 Sep 2019 15:28:32 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: socionext: Fix a signedness bug in ave_probe()

Hi Dan,

Thank you for pointing out.
I've confirmed that this error handling works well with your patch.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>

Thank you,

On Wed, 25 Sep 2019 13:57:50 +0300 <dan.carpenter@...cle.com> wrote:

> The "phy_mode" variable is an enum and in this context GCC treats it as
> an unsigned int so the error handling is never triggered.
> 
> Fixes: 4c270b55a5af ("net: ethernet: socionext: add AVE ethernet driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>  drivers/net/ethernet/socionext/sni_ave.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c
> index 10d0c3e478ab..d047a53f34f2 100644
> --- a/drivers/net/ethernet/socionext/sni_ave.c
> +++ b/drivers/net/ethernet/socionext/sni_ave.c
> @@ -1566,7 +1566,7 @@ static int ave_probe(struct platform_device *pdev)
>  
>  	np = dev->of_node;
>  	phy_mode = of_get_phy_mode(np);
> -	if (phy_mode < 0) {
> +	if ((int)phy_mode < 0) {
>  		dev_err(dev, "phy-mode not found\n");
>  		return -EINVAL;
>  	}
> -- 
> 2.20.1

---
Best Regards,
Kunihiko Hayashi