netdev - Re: [PATCH net-next] net: stmmac: Fix page pool size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190926.092849.214919483212512707.davem@davemloft.net>
Date:   Thu, 26 Sep 2019 09:28:49 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     thierry.reding@...il.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, f.fainelli@...il.com,
        jakub.kicinski@...ronome.com, jonathanh@...dia.com,
        bbiswas@...dia.com, netdev@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: Fix page pool size

From: Thierry Reding <thierry.reding@...il.com>
Date: Mon, 23 Sep 2019 11:59:15 +0200

> From: Thierry Reding <treding@...dia.com>
> 
> The size of individual pages in the page pool in given by an order. The
> order is the binary logarithm of the number of pages that make up one of
> the pages in the pool. However, the driver currently passes the number
> of pages rather than the order, so it ends up wasting quite a bit of
> memory.
> 
> Fix this by taking the binary logarithm and passing that in the order
> field.
> 
> Fixes: 2af6106ae949 ("net: stmmac: Introducing support for Page Pool")
> Signed-off-by: Thierry Reding <treding@...dia.com>

Not only should this have been marked v2, it should have targetted 'net'
instead of 'net-next'.

In any event, I've applied it, thanks.