lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Sep 2019 01:10:19 +0000 From: Dexuan Cui <decui@...rosoft.com> To: Stefano Garzarella <sgarzare@...hat.com> CC: "jhansen@...are.com" <jhansen@...are.com>, "davem@...emloft.net" <davem@...emloft.net>, "stefanha@...hat.com" <stefanha@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Stephen Hemminger <sthemmin@...rosoft.com>, Sasha Levin <Alexander.Levin@...rosoft.com>, "sashal@...nel.org" <sashal@...nel.org>, Haiyang Zhang <haiyangz@...rosoft.com>, KY Srinivasan <kys@...rosoft.com>, Michael Kelley <mikelley@...rosoft.com>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] vsock: Fix a lockdep warning in __vsock_release() > From: Stefano Garzarella <sgarzare@...hat.com> > Sent: Thursday, August 22, 2019 3:25 AM > > [...snipped...] > > --- a/net/vmw_vsock/hyperv_transport.c > > +++ b/net/vmw_vsock/hyperv_transport.c > > @@ -559,7 +559,7 @@ static void hvs_release(struct vsock_sock *vsk) > > struct sock *sk = sk_vsock(vsk); > > bool remove_sock; > > > > - lock_sock(sk); > > + lock_sock_nested(sk, SINGLE_DEPTH_NESTING); > > Should we update also other transports? > > Stefano Hi Stefano, Sorry for the late reply! I'll post a v2 shortly. As I checked, hyperv socket and virtio socket need to be fixed. The vmci socket code doesn't acquire the sock lock in the release callback, so it doesn't need any fix. Thanks, -- Dexuan
Powered by blists - more mailing lists