netdev - 答复: [PATCH] openvswitch: change type of UPCALL_PID attribute to NLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3535a264e3a4dedb3ab9ab88e907b5b@baidu.com>
Date:   Thu, 26 Sep 2019 01:15:35 +0000
From:   "Li,Rongqing" <lirongqing@...du.com>
To:     Pravin Shelar <pshelar@....org>
CC:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: 答复: [PATCH] openvswitch: change type of UPCALL_PID attribute to NLA_UNSPEC



> -----邮件原件-----
> 发件人: Pravin Shelar [mailto:pshelar@....org]
> 发送时间: 2019年9月26日 5:03
> 收件人: Li,Rongqing <lirongqing@...du.com>
> 抄送: Linux Kernel Network Developers <netdev@...r.kernel.org>
> 主题: Re: [PATCH] openvswitch: change type of UPCALL_PID attribute to
> NLA_UNSPEC
> 
> On Tue, Sep 24, 2019 at 4:11 AM Li RongQing <lirongqing@...du.com> wrote:
> >
> > userspace openvswitch patch "(dpif-linux: Implement the API functions
> > to allow multiple handler threads read upcall)"
> > changes its type from U32 to UNSPEC, but leave the kernel unchanged
> >
> > and after kernel 6e237d099fac "(netlink: Relax attr validation for
> > fixed length types)", this bug is exposed by the below warning
> >
> >         [   57.215841] netlink: 'ovs-vswitchd': attribute type 5 has an
> invalid length.
> >
> > Signed-off-by: Li RongQing <lirongqing@...du.com>
> 
> Acked-by: Pravin B Shelar <pshelar@....org>
> 

Add a fixes:

Fixes: 5cd667b0a456 ("openvswitch: Allow each vport to have an array of 'port_id's")

-LI

> Thanks,
> Pravin.