netdev - Re: [PATCH bpf] libbpf: teach btf_dumper to emit stand-alone anonymous enum definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190926124328.GA6563@pc-63.home>
Date:   Thu, 26 Sep 2019 14:43:28 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...com,
        andrii.nakryiko@...il.com, kernel-team@...com
Subject: Re: [PATCH bpf] libbpf: teach btf_dumper to emit stand-alone
 anonymous enum definitions

On Wed, Sep 25, 2019 at 01:37:45PM -0700, Andrii Nakryiko wrote:
> BTF-to-C converter previously skipped anonymous enums in an assumption
> that those are embedded in struct's field definitions. This is not
> always the case and a lot of kernel constants are defined as part of
> anonymous enums. This change fixes the logic by eagerly marking all
> types as either referenced by any other type or not. This is enough to
> distinguish two classes of anonymous enums and emit previously omitted
> enum definitions.
> 
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Applied, thanks!